Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hardhat plugin to support HTS emulation in fork testing #50

Merged
merged 14 commits into from
Oct 4, 2024

Conversation

arianejasuwienas
Copy link
Contributor

@arianejasuwienas arianejasuwienas commented Sep 25, 2024

Description:
Hardhat plugin allowing users to test HTS on the forked networks . Will provide developers with the possibility to use the custom hardhat provider that will preset the precompile byte code on the network as well as fill the storage slots related to the currently used tokens.

Related issue(s):

#44

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas arianejasuwienas requested review from a team as code owners September 25, 2024 11:44
@arianejasuwienas arianejasuwienas self-assigned this Sep 25, 2024
@arianejasuwienas arianejasuwienas added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Sep 25, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arianejasuwienas great to have this. I see there are leftovers from the Hardhat template, can we remove all of these?

tools/hardhat-forking-plugin/.editorconfig Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/.eslintignore Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/.eslintrc.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/CHANGELOG.md Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/.travis.yml Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/client.ts Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/tsconfig.json Outdated Show resolved Hide resolved
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work.
Lots of comments (questions and suggestions)

Also please update the PR description to give reviewers and idea of what changes you're suggesting for review

tools/hardhat-forking-plugin-usage-example/.env.example Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin-usage-example/.env.example Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/hedera-provider.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/hedera-provider.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/hedera-provider.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/README.md Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/index.js Outdated Show resolved Hide resolved
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
tools/hardhat-forking-plugin/src/index.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/index.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/hedera-provider.js Outdated Show resolved Hide resolved
tools/hardhat-forking-plugin/src/utils.js Outdated Show resolved Hide resolved
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
…thing more to be here

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas arianejasuwienas mentioned this pull request Oct 3, 2024
2 tasks
@acuarica
Copy link
Contributor

acuarica commented Oct 3, 2024

@arianejasuwienas see if you can fix DCO error https://github.com/hashgraph/hedera-forking/pull/50/checks?check_run_id=31028928684 after merging the PR. Moreover, please add a description for this PR and title.

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
Copy link
Contributor Author

I've fixed it, but I'm not sure if that was the smartest way to do it (rebase, reset head , commit again), since now I'm the author of your changes as well. But since we will lose the commit history anyway when merging the PR perhaps this approach is good enough? Let me know @acuarica .

@acuarica
Copy link
Contributor

acuarica commented Oct 3, 2024

@arianejasuwienas yes, that's good enough, thanks for the heads up and for taking care of this.

.github/workflows/test.yml Outdated Show resolved Hide resolved
…ed (for current config options) file.

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas arianejasuwienas changed the title 44 hardhat plugin feat: hardhat plugin for hedera hts support Oct 4, 2024
@arianejasuwienas arianejasuwienas changed the title feat: hardhat plugin for hedera hts support feat: add hardhat plugin to support HTS emulation in fork testing Oct 4, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Will comment in follow up if any

@acuarica acuarica merged commit c3e13f8 into main Oct 4, 2024
9 checks passed
@acuarica acuarica deleted the 44-hardhat-plugin branch October 4, 2024 22:44
@acuarica acuarica added feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. and removed New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hardhat] Investigate the possibility to "embed" the hedera-forking package into Hardhat
3 participants