-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hardhat plugin to support HTS emulation in fork testing #50
Conversation
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arianejasuwienas great to have this. I see there are leftovers from the Hardhat template, can we remove all of these?
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work.
Lots of comments (questions and suggestions)
Also please update the PR description to give reviewers and idea of what changes you're suggesting for review
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
…thing more to be here Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas see if you can fix DCO error https://github.com/hashgraph/hedera-forking/pull/50/checks?check_run_id=31028928684 after merging the PR. Moreover, please add a description for this PR and title. |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
24f048c
to
923b122
Compare
I've fixed it, but I'm not sure if that was the smartest way to do it (rebase, reset head , commit again), since now I'm the author of your changes as well. But since we will lose the commit history anyway when merging the PR perhaps this approach is good enough? Let me know @acuarica . |
@arianejasuwienas yes, that's good enough, thanks for the heads up and for taking care of this. |
…ed (for current config options) file. Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Will comment in follow up if any
Description:
Hardhat plugin allowing users to test HTS on the forked networks . Will provide developers with the possibility to use the custom hardhat provider that will preset the precompile byte code on the network as well as fill the storage slots related to the currently used tokens.
Related issue(s):
#44
Notes for reviewer:
Checklist