-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP-1056: Block Streams #1056
Draft
rbair23
wants to merge
29
commits into
main
Choose a base branch
from
block-streams
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
HIP-1056: Block Streams #1056
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8a9a980
Initial upload of the block stream HIP
rbair23 f56a4f5
Update with HIP #
rbair23 51d17a1
Merge f56a4f588c66cb85c3a76a36d743526a799925b0 into da405eec611610992…
rbair23 33d5768
Assigning HIP 1056 and renaming file to hip-1056.md
actions-user a5cff30
Added round header item image and addressed comments
Nana-EC dc22fd1
Add updated block stream merkle svg and rejected ideas
Nana-EC 2b44d4e
More updates and added open Issues
Nana-EC 1cd4d6f
Pushed comunity wording fix suggestions. Thanks Kelly, Michael T, Der…
Nana-EC e7d07d1
Fixed proto indents
Nana-EC bddecaf
Addressed comments up to 11/17/24. Thanks jsync-swirlds, poulok, stev…
Nana-EC b979ffd
Fixed image paths, added proof types and started a table with options
Nana-EC 8b1f83d
Added side car and signature sto diagram and added proof scenarios
Nana-EC a73475c
Fix table contents
Nana-EC 470b928
Cleaned up platform related proto
Nana-EC 6c76dce
Cleaned up and address some comments
Nana-EC e72e10a
Fix background images
Nana-EC e79b9a4
Add protofuf asset files
Nana-EC 79719fc
Minor changes and removed block service
Nana-EC 49722aa
Removed block file concept and updated open issues
Nana-EC ecdf2ef
Fix HSCS transaction outputs
Nana-EC b878ace
Push fixed HSC proto
Nana-EC e34a186
More fixes and improvemnts in text and proto
Nana-EC 0c4c239
Added a good chunk or proto indentation
Nana-EC a01b57f
Update sidecar references and Open Issues
Nana-EC 03784ce
Added clarification regarding consistency of singleton and queue stat…
Nana-EC 63bd540
Removed ContractStateChange as it's contents are covered by StateChan…
Nana-EC ec00e89
Megamap reference added to open issues
Nana-EC fd643cc
Moved automatic_token_associations and token_transfer_lists out of Tr…
Nana-EC 231a137
Updated sentence on platform state changes
Nana-EC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
poulok marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really decide what terms we are going to use. Some places use stake weights and others simply use weight. Either is fine as long as it is used consistently. Inconsistent use will contribute to confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to stake weight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot that I said "either is fine" in this comment. I posted another comment above saying that "stake weight" is confusing. I've always thought this, but know it's a commonly used term so I must have been feeling particularly lenient the day i made this original comment. Happy to discuss offline. I don't want to cause uncecessary churn.