Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable KeyList Support in HTS Precompile #1069

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mgarbs
Copy link
Collaborator

@mgarbs mgarbs commented Oct 31, 2024

Enable KeyList Support in HTS updateTokenKeys Precompile

This update adds support for using complex keys (KeyLists ) within the updateTokenKeys HTS precompile function, allowing developers to set token keys with multiple signatories directly in smart contracts. While complex keys are supported in the SDK, this enhancement allows on-chain token management with multi-signature and threshold-controlled permissions, expanding flexibility for applications requiring decentralized control over token keys.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit ca1f95b
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/6723d16b06327f000837cd28
😎 Deploy Preview https://deploy-preview-1069--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


IHederaTokenService.TokenKey memory key = IHederaTokenService.TokenKey({
keyType: KeyType.SUPPLY,
key: KeyList({
Copy link
Contributor

@stoyanov-st stoyanov-st Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Are we aiming to support both KeyList and Threshold key types? I can see only KeyList mentioned but this example is using a Threshold type for the KeyList.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to simplify the HIP and only support threshold key types with threshold = 1.

This will satisfy the use case where developers want to define a list of potential administrators for a specific function (i.e. supply key), each with the same permissions.

I don't think other cases are technically feasible: since Ethereum lacks the concept of native multi signature transactions, we will never reach a threshold > 1 in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants