-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wagmi example usage with Hedera #3000
Conversation
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, minor suggestions.
Also images or short video are great attachments to the PR to should the UI representation of the code since it can't be seen by just reviewing the code
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
8334732
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, please share details around the solc version choice though in follow up
… about them was no longer valid Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
f3eb395
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
==========================================
+ Coverage 77.06% 84.91% +7.85%
==========================================
Files 40 58 +18
Lines 3266 3905 +639
Branches 683 784 +101
==========================================
+ Hits 2517 3316 +799
+ Misses 529 348 -181
- Partials 220 241 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
* feat: Wagmi example usage with Hedera Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com> * chore: typo in readme, remove unused import Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com> * chore: typo in readme, cleanup in code Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com> * chore: change pnpm to npm, small fixes Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com> * feat: pr suggestions applied Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> * feat: pr suggestions applied Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> * feat: cancuns opcodes are supported in hedera already so this comment about them was no longer valid Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> --------- Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com> Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com> Co-authored-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Description:
Validate wagmi support and add example usage with hedera
Related issue(s):
Implements: #2802
Checklist