ci: Updating permissions within manual-testing to resolve workflow issue. #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue. Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
san-est
requested review from
AlfredoG87,
ebadiere,
Nana-EC and
a team
as code owners
|
victor-yanev
approved these changes
Sep 19, 2024
Nana-EC
approved these changes
Sep 19, 2024
nathanklick
approved these changes
Sep 19, 2024
quiet-node
approved these changes
Sep 19, 2024
rbarkerSL
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
==========================================
+ Coverage 89.92% 89.93% +0.01%
==========================================
Files 58 61 +3
Lines 3900 4053 +153
Branches 780 815 +35
==========================================
+ Hits 3507 3645 +138
- Misses 346 358 +12
- Partials 47 50 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
victor-yanev
restored the
3017-fix-issue-in-workflowsmanual-testingyml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is an issue in the manual-testing workflow file, the acceptance workflow requires actions: read permissions but its not getting them when manual testing is ran. Initially I thought they were not defined in the acceptance workflow file but everything seems to be fine there so adding permissions here.
Related issue(s):
Fixes #3017
Notes for reviewer:
Checklist