Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unnecessary script signTransaction #3087

Merged

Conversation

nadezhdapopovaa
Copy link
Contributor

Description:
Delete unnecessary script signTransaction.js

Fixes #3086

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@nadezhdapopovaa nadezhdapopovaa requested a review from a team as a code owner October 10, 2024 08:11
@nadezhdapopovaa nadezhdapopovaa linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link

@nadezhdapopovaa nadezhdapopovaa added the bug Something isn't working label Oct 10, 2024
@nadezhdapopovaa nadezhdapopovaa added this to the 0.58.0 milestone Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 32,624 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.72 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 344.06 KB
  • Total Available Size: increased with 2.83 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.38 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 2.10 MB
    • Space Used Size: increased with 1.99 MB
    • Space Available Size: decreased with 56.01 KB
    • Physical Space Size: increased with 2.10 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

github-actions bot commented Oct 10, 2024

Acceptance Tests

  19 files  236 suites   33m 4s ⏱️
603 tests 593 ✔️ 4 💤 6
648 runs  638 ✔️ 4 💤 6

Results for commit cceb716.

♻️ This comment has been updated with latest results.

Copy link

Tests

       3 files     300 suites   19s ⏱️
1 359 tests 1 358 ✔️ 1 💤 0
1 368 runs  1 367 ✔️ 1 💤 0

Results for commit cceb716.

@nadezhdapopovaa nadezhdapopovaa merged commit ec19625 into main Oct 10, 2024
43 of 44 checks passed
@nadezhdapopovaa nadezhdapopovaa deleted the 3086-remove-unnecessary-script-signtransaction branch October 10, 2024 11:09
konstantinabl pushed a commit that referenced this pull request Oct 15, 2024
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@quiet-node quiet-node added internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed bug Something isn't working labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (1c65943) to head (cceb716).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3087   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          59       59           
  Lines        3939     3939           
  Branches      788      788           
=======================================
  Hits         3342     3342           
  Misses        359      359           
  Partials      238      238           
Flag Coverage Δ
relay 84.95% <ø> (ø)
server 83.43% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary script signTransaction
4 participants