fix: bugged metrics and wrong env vars

[victor-yanev]

Description:

• Removes the "daily" keyword from everywhere since it's no longer valid
• Resets the metrics for unique spending plans used together with the reset of the HBAR limiter (because when the limiter is restarted all BASIC plans will expire and on next requests from the same ETH addresses they will be considered as new unique BASIC plans and this metric won't make sense anymore unless we reset the metric together with the limiter)
• Fixes wrong env vars in constants.ts

Related issues:

Fixes #3092

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 29,356.6 ms

Heap Statistics (before vs after executing the test):

• Total Heap Size: increased with 1.46 MB
• Total Heap Size Executable: no changes
• Total Physical Size: decreased with 348.16 KB
• Total Available Size: decreased with 5.37 MB
• Total Global Handles Size: no changes
• Used Global Handles Size: decreased with 64.00 bytes
• Used Heap Size: decreased with 3.44 MB
• Heap Size Limit: no changes
• Malloced Memory: no changes
• External Memory: no changes
• Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

• Old Space:

  • Space Size: increased with 1.84 MB
  • Space Used Size: increased with 2.08 MB
  • Space Available Size: decreased with 8.73 MB
  • Physical Space Size: increased with 1.84 MB

• Large Object Space:

  • Space Size: increased with 835.58 KB
  • Space Used Size: increased with 813.50 KB
  • Space Available Size: no changes
  • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[quiet-node]

LGTM

[github-actions]

Tests

       3 files     398 suites   18s ⏱️
1 428 tests 1 427 ✔️ 1 💤 0 ❌
1 437 runs  1 436 ✔️ 1 💤 0 ❌

Results for commit 0da22ff.

[github-actions]

Acceptance Tests

  20 files  276 suites   33m 57s ⏱️
600 tests 592 ✔️ 4 💤 4 ❌
704 runs  694 ✔️ 4 💤 6 ❌

Results for commit 0da22ff.

[ebadiere]

LG.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (1f776e6) to head (0da22ff).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3090   +/-   ##
=======================================
  Coverage   83.15%   83.16%           
=======================================
  Files          63       63           
  Lines        4232     4234    +2     
  Branches      830      830           
=======================================
+ Hits         3519     3521    +2     
  Misses        470      470           
  Partials      243      243           

Flag	Coverage Δ
relay	85.59% <100.00%> (+<0.01%)	⬆️
server	83.43% <ø> (ø)
ws-server	33.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/relay/src/lib/constants.ts	92.00% <100.00%> (ø)
...s/relay/src/lib/services/hbarLimitService/index.ts	97.47% <100.00%> (+0.04%)	⬆️