Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating workflows/actions to be compatible to and updating to the step-security maintained version. #3108

Merged

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Oct 16, 2024

Description:
The previous attempt to upgrade to the step-security version of the workflows resulted in an issue as there was mismatch in the inputs between the versions. This should now be resolved and this PR contains the changed inputs as well as the upgrade to the step-security maintained version of the action.

Related issue(s):

Fixes #2943

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ep-security maintained version.

Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>

Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>

Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
…ep-security maintained version.

Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>

Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>

Resolving conflicts and rebasing.
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
…ade-path-for-publish-unit-test-result-action' into 2943-determine-upgrade-path-for-publish-unit-test-result-action

Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
Signed-off-by: Vasil Boyadzhiev <vasil.boyadzhiev@limechain.tech>
@san-est san-est added this to the 0.59.0 milestone Oct 16, 2024
@san-est san-est self-assigned this Oct 16, 2024
@san-est san-est requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners October 16, 2024 11:18
Copy link

Copy link

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 30,622.5 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.72 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 86.02 KB
  • Total Available Size: decreased with 10.14 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.44 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 2.10 MB
    • Space Used Size: increased with 2.07 MB
    • Space Available Size: decreased with 13.03 MB
    • Physical Space Size: increased with 2.10 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

github-actions bot commented Oct 16, 2024

Test Results

 18 files  260 suites   30m 59s ⏱️
602 tests 592 ✅ 4 💤 6 ❌
726 runs  714 ✅ 6 💤 6 ❌

For more details on these failures, see this check.

Results for commit 071d442.

♻️ This comment has been updated with latest results.

@san-est san-est merged commit 1ad7040 into main Oct 23, 2024
45 of 47 checks passed
@san-est san-est deleted the 2943-determine-upgrade-path-for-publish-unit-test-result-action branch October 23, 2024 07:13
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 91.96850% with 51 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (a3615c5) to head (071d442).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
packages/relay/src/lib/clients/sdkClient.ts 55.55% 12 Missing ⚠️
packages/relay/src/lib/eth.ts 92.56% 10 Missing and 1 partial ⚠️
packages/relay/src/lib/types/RequestDetails.ts 45.45% 6 Missing ⚠️
packages/relay/src/lib/clients/mirrorNodeClient.ts 91.66% 3 Missing ⚠️
...barLimiter/ethAddressHbarSpendingPlanRepository.ts 88.88% 0 Missing and 3 partials ⚠️
...ay/src/lib/config/hbarSpendingPlanConfigService.ts 97.80% 0 Missing and 2 partials ⚠️
packages/relay/src/lib/constants.ts 71.42% 0 Missing and 2 partials ⚠️
...hbarLimiter/ipAddressHbarSpendingPlanRepository.ts 92.30% 0 Missing and 2 partials ⚠️
packages/relay/src/lib/poller.ts 66.66% 2 Missing ⚠️
packages/relay/src/lib/relay.ts 89.47% 1 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3108      +/-   ##
==========================================
- Coverage   84.91%   83.16%   -1.75%     
==========================================
  Files          58       63       +5     
  Lines        3905     4236     +331     
  Branches      784      830      +46     
==========================================
+ Hits         3316     3523     +207     
- Misses        348      470     +122     
- Partials      241      243       +2     
Flag Coverage Δ
relay 85.59% <91.96%> (+0.47%) ⬆️
server 83.48% <ø> (+0.42%) ⬆️
ws-server 33.91% <ø> (-63.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/cache/redisCache.ts 93.00% <100.00%> (+1.69%) ⬆️
...sitories/hbarLimiter/hbarSpendingPlanRepository.ts 100.00% <100.00%> (ø)
...kages/relay/src/lib/db/types/hbarLimiter/errors.ts 100.00% <100.00%> (ø)
...y/src/lib/db/types/hbarLimiter/subscriptionTier.ts 100.00% <100.00%> (ø)
packages/relay/src/lib/hbarlimiter/index.ts 100.00% <100.00%> (ø)
packages/relay/src/lib/precheck.ts 90.62% <100.00%> (-0.64%) ⬇️
...elay/src/lib/services/cacheService/cacheService.ts 92.48% <100.00%> (ø)
...kages/relay/src/lib/services/debugService/index.ts 76.47% <100.00%> (ø)
.../relay/src/lib/services/hapiService/hapiService.ts 80.00% <100.00%> (ø)
packages/relay/src/lib/subscriptionController.ts 100.00% <100.00%> (ø)
... and 28 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine upgrade path for publish-unit-test-result-action
3 participants