chore: cherry pick #3268 to release/0.60 #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
lukelee-sl and
a team
as code owners
Test Results 20 files - 2 279 suites - 3 31m 20s ⏱️ - 4m 41s For more details on these failures, see this check. Results for commit 3dd806c. ± Comparison against base commit 6a9acb2. ♻️ This comment has been updated with latest results. |
…ent (#3268) * removes request details from passed arg to MN client Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Masks ip beforehand instead of changing object in repeated request Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds constant and draft unit test Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * changes unit test Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes unit test Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * removes unused var Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
cherry-pick-3268
branch
from
665485d to
3dd806c
Compare
|
konstantinabl
approved these changes
Nov 19, 2024
Nana-EC
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.60 #3277 +/- ##
=============================================
Coverage 77.88% 77.89%
=============================================
Files 66 66
Lines 4468 4470 +2
Branches 1003 1003
=============================================
+ Hits 3480 3482 +2
Misses 613 613
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick fix: masks ip address in request details passed as argument to MN client (#3268) to release/0.60
Related issue(s):
Fixes #3268
Notes for reviewer:
Checklist