feat: transaction with CONTRACT_NEGATIVE_VALUE breaks some routes
#3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Test Results 18 files - 7 236 suites - 151 32m 48s ⏱️ - 40m 17s Results for commit c17f02a. ± Comparison against base commit 67b61c6. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
- Coverage 84.87% 84.77% -0.11%
==========================================
Files 69 69
Lines 4742 4750 +8
Branches 1067 1069 +2
==========================================
+ Hits 4025 4027 +2
- Misses 400 405 +5
- Partials 317 318 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
quiet-node
requested changes
Jan 15, 2025
| @@ -265,6 +266,33 @@ const nanOrNumberTo0x = (input: number | BigNumber | bigint | null): string => { | |||
| return input == null || Number.isNaN(input) ? numberTo0x(0) : numberTo0x(input); | |||
| }; | |||
|
|
|||
| const nanOrNumberInt64To0x = (input: number | BigNumber | bigint | null): string => { | |||
| if (input && input < 0) { | |||
There was a problem hiding this comment.
This got a warning
Operator '<' cannot be applied to types 'number | bigint | BigNumber' and 'number'.ts(2365)
Comment on lines
+271
to
+288
| // the hex of a negative number can be obtained from the binary value of that number positive value | ||
| // the binary value needs to be negated and then to be incremented by 1 | ||
|
|
||
| // how the transformation works (using 16 bits) | ||
| // a 16 bits integer variables have values from -32768 to +32767, so: | ||
| // 0 - 0x0000 - 0000 0000 0000 0000 | ||
| // 32767 - 0x7fff - 0111 1111 1111 1111 | ||
| // -32768 - 0x8000 - 1000 0000 0000 0000 | ||
| // -1 - 0xffff - 1111 1111 1111 1111 | ||
|
|
||
| // converting int16 -10 will be done as following: | ||
| // - make it positive = 10 | ||
| // - 16 bits binary value of 10 = 0000 0000 0000 1010 | ||
| // - inverse the bytes = 1111 1111 1111 0101 | ||
| // - adding +1 = 1111 1111 1111 0110 | ||
| // - 1111 1111 1111 0110 bits = 0xfff6 | ||
|
|
||
| // we're using 64 bits integer because that the type returned by the mirror node - int64 |
acuarica
reviewed
Jan 16, 2025
|
|
||
| // we're using 64 bits integer because that the type returned by the mirror node - int64 | ||
| const bits = 64; | ||
| return numberTo0x((BigInt(input.toString()) + (BigInt(1) << BigInt(bits))) % (BigInt(1) << BigInt(bits))); |
There was a problem hiding this comment.
question: do we expect number bigger than 53 bits? so it's not automatically coerced to double https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It seems like
eth_getBlockByNumberfails because one of the transactions in the block was a CONTRACT_NEGATIVE_VALUE failure. The expectation is for the block to be successfully returned.Steps to reproduce:
eth_getBlockByNumberon block 73298898The problematic transaction is here
Related issue(s):
Fixes #3367
Notes for reviewer:
Checklist