Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ContractCallNestedCallsHistoricalTest #8956

Closed
Tracked by #8057
bilyana-gospodinova opened this issue Aug 6, 2024 · 0 comments · Fixed by #9164
Closed
Tracked by #8057

Refactor ContractCallNestedCallsHistoricalTest #8956

bilyana-gospodinova opened this issue Aug 6, 2024 · 0 comments · Fixed by #9164
Assignees
@kselveliev
Labels
enhancement Type: New feature technical debt test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Milestone
0.113.0

Comments

@bilyana-gospodinova
Copy link
Contributor

Problem

During the refactoring of the integration tests to use web3j the historical test cases were moved to ContractCallNestedCallsHistoricalTest and they nee to be refactored to use the plugin as well. The PR for the movement is #8955.

Solution

Refactor ContractCallNestedCallsHistoricalTest to use the web3j plugin.

Alternatives

No response
@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API labels Aug 6, 2024
@bilyana-gospodinova bilyana-gospodinova mentioned this issue Aug 6, 2024
Closed
@bilyana-gospodinova bilyana-gospodinova changed the title Refactor ContractCallNestedCallsHistoricalTest Refactor ContractCallNestedCallsHistoricalTest Aug 7, 2024
@steven-sheehy steven-sheehy added this to the 0.113.0 milestone Aug 17, 2024
@kselveliev kselveliev self-assigned this Aug 26, 2024
@kselveliev kselveliev mentioned this issue Aug 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kselveliev kselveliev

Labels
enhancement Type: New feature technical debt test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
Mirror Node
Status: ✅ Done
Milestone
0.113.0
Development

Successfully merging a pull request may close this issue.

Refactor ContractCallNestedCallsHistoricalTest hashgraph/hedera-mirror-node
3 participants
@steven-sheehy @kselveliev @bilyana-gospodinova