Refactor ContractCallNestedCallsHistoricalTest #9164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev
requested review from
bilyana-gospodinova,
IvanKavaldzhiev,
steven-sheehy and
nickeynikolovv
kselveliev
added
limechain
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9164 +/- ##
=========================================
Coverage 92.14% 92.14%
- Complexity 7713 7714 +1
=========================================
Files 933 933
Lines 30823 30823
Branches 3762 3762
=========================================
Hits 28402 28402
Misses 1575 1575
Partials 846 846 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
|
steven-sheehy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr refactors
ContractCallNestedCallsHistoricalTestto use the web3j plugin and use native java type.The class test 3 method
getTokenInfo,getApprovedandmintNftin historical context.The historical context is for blocks pre evm 34 version.
This PR modifies:
TestWeb3jService- Adds a new check to execute estimate gas calls only when we are not in historical context since estimate gas does not support historical blocks.Added
NestedCallHistorical.sol file. Modified the 3 tests to not return "hardcoded result" but instead take the response from the Hts call.Modified
ContractCallNestedCallsHistoricalTestto use the new approach with web3j.Related issue(s):
Fixes #8956
Notes for reviewer:
Checklist