148 bug freeze transaction missing #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2019 02:28
…type not known Signed-off-by: Greg Scullard <gregscullard@hedera.com>
…sed by mirror node) Signed-off-by: Greg Scullard <gregscullard@hedera.com>
steven-sheehy
approved these changes
Aug 29, 2019
delete-merged-branch
bot
deleted the
148-bug-freeze-transaction-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Corrects a number of issues with transaction types:
-When a transaction type is unknown to mirror node, an NPE occurred while attempting to fetch an "unknown" key from a hash map instead of "UNKNOWN"
-The freeze transaction type was missing from the database
-The proto_id for transaction types was incorrect. It was pulled from the
HederaFunctionalityenum inBasicTypes.protoinstead of theoneof datainTransactionBody.protoWhich issue(s) this PR fixes:
Fixes #148
Checklist