Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI caching #153

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fix CircleCI caching #153

merged 1 commit into from
Aug 29, 2019

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Aug 29, 2019

Detailed description:
Fix Maven caching to check pom.xml checksum so cache is updated on changes. Previously save_cache staged said Skipping cache generation, cache already exists for key: maven despite there showing downloads in mvn install.

Which issue(s) this PR fixes:

Special notes for your reviewer:
The 3 cache keys are for the same cache and help reduce build conflicts between branches

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Aug 29, 2019
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 29, 2019
@steven-sheehy steven-sheehy self-assigned this Aug 29, 2019
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@mike-burrage-hedera mike-burrage-hedera merged commit a03b399 into master Aug 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the circleci-caching branch August 29, 2019 20:05
@steven-sheehy steven-sheehy added P3 process Build or test related tasks labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P3 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants