Handle duplicate transactions correctly by using consensus_ns as the key #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of transaction-id since the transaction-ids are not unique. Signed-off-by: atul mahamuni <atulmahamuni@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of transaction-id since the transaction-ids are not unique.
Signed-off-by: atul mahamuni atulmahamuni@hedera.com
Detailed description:
If the user submits the same transaction to more than one nodes, the first one succeeds, and the other copies (duplicates) are still charged the transaction processing fees, and hence they show up in the record stream. So the record stream could have multiple entries for the same transaction-ids. Currently, the code had assumed that the transaction-id is unique. Made the change to use consensus_ns as a unique key.
Which issue(s) this PR fixes:
Fixes #205
Checklist