-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ed25519 key explicitly and remove admin_key in t_entities #217
Conversation
47813b0
to
edc0af7
Compare
edc0af7
to
4a3ecfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly I was thinking about the same thing last night !
See suggested changes, would also suggest adding a unit test including a valid key in upper case to test it comes out of utility.protobufKeyToHexIfEd25519OrNull
in lowercase.
…ntities.ed25519_public_key_hex. Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
4f99bbe
to
16bc1b0
Compare
Can't have a unit test where utility.protobufKeyToHexIfEd25519OrNull() produces uppercase, since it always produces lowercase, but I updated the javadoc on it to make that explicit. |
Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
I meant provide it an uppercase input, validate output is lowercase. |
There is no uppercase or lowercase input - the input is raw binary bits of the protobuf that |
Detailed description:
key column will now be used in place of admin_key where admin_key was used in the past. No entity had both
Which issue(s) this PR fixes:
Fixes #56
Special notes for your reviewer:
Checklist