Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileWatcher fixes #43

Merged
merged 1 commit into from
Aug 16, 2019
Merged

FileWatcher fixes #43

merged 1 commit into from
Aug 16, 2019

Conversation

steven-sheehy
Copy link
Member

  • MacOS does support a simple polling only FileWatcher
  • Don't register watch in a loop
  • Don't stop on InterruptedException
  • Ignore OVERFLOW events

@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Aug 15, 2019
@steven-sheehy steven-sheehy merged commit 4a73d3c into master Aug 16, 2019
@steven-sheehy steven-sheehy deleted the file-watcher-fixes branch August 16, 2019 19:43
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added P2 parser Area: File parsing labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burrage-hedera mike-burrage-hedera mike-burrage-hedera approved these changes

@gregscullard gregscullard Awaiting requested review from gregscullard

Assignees
No one assigned
Labels
bug Type: Something isn't working P2 parser Area: File parsing
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-sheehy @mike-burrage-hedera