Fix balance monitor api tests #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'live' and not tied to the REST API /balances timestamp. Signed-off-by: Marc Kriguer <marc.kriguer@swirldslabs.com>
MarcKriguerAtHedera
added
bug
Signed-off-by: Marc Kriguer <marc.kriguer@swirldslabs.com>
Codecov ReportBase: 92.53% // Head: 92.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
============================================
- Coverage 92.53% 92.51% -0.03%
+ Complexity 2954 2952 -2
============================================
Files 542 544 +2
Lines 17426 17508 +82
Branches 1836 1850 +14
============================================
+ Hits 16125 16197 +72
- Misses 949 959 +10
Partials 352 352
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
steven-sheehy
changed the title
steven-sheehy
previously approved these changes
Oct 18, 2022
Signed-off-by: Marc Kriguer <marc.kriguer@swirldslabs.com>
MarcKriguerAtHedera
dismissed stale reviews from xin-hedera and steven-sheehy
via
203e3bc
|
Kudos, SonarCloud Quality Gate passed!
|
steven-sheehy
approved these changes
Oct 18, 2022
xin-hedera
approved these changes
Oct 18, 2022
MarcKriguerAtHedera
deleted the
04674-fix-balances-monitor-tests-for-live-balances
branch
MarcKriguerAtHedera
added a commit
that referenced
this pull request
Oct 18, 2022
* Fix balance monitor api tests to handle the fact that balnces are now 'live' and not tied to the REST API /balances timestamp. Signed-off-by: Marc Kriguer <marc.kriguer@swirldslabs.com>
MarcKriguerAtHedera
added a commit
that referenced
this pull request
Oct 18, 2022
* Fix balance monitor api tests to handle the fact that balnces are now 'live' and not tied to the REST API /balances timestamp. Signed-off-by: Marc Kriguer <marc.kriguer@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix balance monitor api tests to reflect the fact that balances are now 'live' and not tied to the REST API
/balancesresponse timestamp.checkBalanceFreshnesscall to specify timestamp =getBalancesWithTimeAndLimitParamscheck since it no longer makes sense with live balances.Related issue(s):
Fixes #4674
Notes for reviewer:
Checklist