Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix balance parser exhausting connections #59

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Aug 20, 2019
@steven-sheehy steven-sheehy self-assigned this Aug 20, 2019
@steven-sheehy
Copy link
Member Author

I checked other areas of the code and they either open connection once in constructor and never close or they open and close it between uses, so they're safe. Long term they should be refactored to use try-with-resources.

Copy link
Contributor

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@gregscullard gregscullard merged commit f60c2aa into master Aug 20, 2019
@gregscullard gregscullard deleted the fix-balance-parser branch August 20, 2019 21:43
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added P1 parser Area: File parsing labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 parser Area: File parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileWatcher not notified of files created while down
2 participants