Bug/no partial files - fixes #36 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #36 |
src/main/java/com/hedera/downloader/AccountBalancesDownloader.java
Outdated
Show resolved
Hide resolved
mike-burrage-hedera
suggested changes
Aug 21, 2019
steven-sheehy
requested changes
Aug 21, 2019
src/main/java/com/hedera/downloader/AccountBalancesDownloader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hedera/downloader/EventStreamFileDownloader.java
Outdated
Show resolved
Hide resolved
Consolidated where you suggested and more. |
steven-sheehy
approved these changes
Aug 22, 2019
mike-burrage-hedera
approved these changes
Aug 22, 2019
steven-sheehy
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First downloads record, balance and event files to a .../tmp folder.
When download completes, file is moved to .../valid folder.
Also, original code skipped downloading signature files that already existed, I've removed that check such that partial downloads of signature files don't result in permanently truncated files.
No need to first download signatures into a /tmp folder, they are processed after download in the same thread/process as the downloading itself.