Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #84

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Logging improvements #84

merged 4 commits into from
Aug 23, 2019

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Aug 23, 2019 •
edited
Loading

  • Moved log4j2.xml back into the jar so it logs by default to stdout and logs/hedera-mirror-node.log. To adjust the logging, users can copy existing and pass via -Dlog4j.configurationFile=./log4j2.xml
  • Remove use of markers and use full package + class name. Markers should only be used to log cross cutting concerns (e.g. security, monitoring, etc).
  • Adjusted logging levels to be more appropriate. Some areas like record parsing were way too verbose.
  • Use Lombok to generate logging statement
  • Adding elapsed time to most of the important areas
  • Removed unused BucketList.java
  • Removed System.out.println(), e.printStackTrace() and string concatenation in log statements
  • Fixed BalanceFileLogger not rolling back on non-SQLExceptions
  • Fixed BalanceFileLogger continuing after SQLException for latest balance
  • Fixed Utility.extractHashAndSigFromFile() from returning a partial hash and sig.

Sorry for the large PR.

@steven-sheehy steven-sheehy self-assigned this Aug 23, 2019
mike-burrage-hedera
mike-burrage-hedera previously approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@mike-burrage-hedera mike-burrage-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gregscullard
gregscullard approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@gregscullard gregscullard merged commit b1dd43d into master Aug 23, 2019
@steven-sheehy steven-sheehy deleted the logging-improvements branch August 23, 2019 19:12
@steven-sheehy steven-sheehy mentioned this pull request Aug 23, 2019
Closed
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added enhancement Type: New feature P3 process Build or test related tasks technical debt labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregscullard gregscullard gregscullard approved these changes

@mike-burrage-hedera mike-burrage-hedera mike-burrage-hedera left review comments

Assignees

@steven-sheehy steven-sheehy

Labels
enhancement Type: New feature P3 process Build or test related tasks technical debt
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@steven-sheehy @gregscullard @mike-burrage-hedera