Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ConfigLoader.save method calls #88

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Remove unnecessary ConfigLoader.save method calls #88

merged 3 commits into from
Aug 23, 2019

Conversation

gregscullard
Copy link
Contributor

@gregscullard gregscullard commented Aug 23, 2019 •
edited by steven-sheehy
Loading

Removes the unnecessary ConfigLoader.saveToFile() calls

Fixes #77

steven-sheehy
steven-sheehy approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit c775748 into master Aug 23, 2019
@steven-sheehy steven-sheehy deleted the fix/removeConfigLoaderSave branch August 23, 2019 16:46
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

Assignees
No one assigned
Labels
bug Type: Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Remove ConfigLoader.saveToFile();
2 participants
@gregscullard @steven-sheehy