Calculate acceptance test operator balance from USD #8957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
steven-sheehy
added
enhancement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8957 +/- ##
=========================================
Coverage 92.20% 92.20%
Complexity 7624 7624
=========================================
Files 927 927
Lines 30503 30503
Branches 3721 3721
=========================================
Hits 28126 28126
Misses 1550 1550
Partials 827 827 ☔ View full report in Codecov by Sentry. |
jnels124
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Add a feature flag for rejectToken so mirror node can deploy before services 0.52 * Change `operatorBalance` property to store amount in USD * Change operator initial balance to convert USD into tinybar using `transactionReceipt.ExchangeRate` or falling back to `/api/v1/network/exchangerate` * Fix assertion not printing out correct contract call response * Fix regression caused by null immutable key * Fix startup probe topic not being deleted * Fix startup probe taking forever to recover when all nodes are down Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> (cherry picked from commit f72fe73)
jnels124
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Add a feature flag for rejectToken so mirror node can deploy before services 0.52 * Change `operatorBalance` property to store amount in USD * Change operator initial balance to convert USD into tinybar using `transactionReceipt.ExchangeRate` or falling back to `/api/v1/network/exchangerate` * Fix assertion not printing out correct contract call response * Fix regression caused by null immutable key * Fix startup probe topic not being deleted * Fix startup probe taking forever to recover when all nodes are down Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> (cherry picked from commit f72fe73) Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
steven-sheehy
added a commit
that referenced
this pull request
Aug 6, 2024
Calculate acceptance test operator balance from USD (#8957) * Add a feature flag for rejectToken so mirror node can deploy before services 0.52 * Change `operatorBalance` property to store amount in USD * Change operator initial balance to convert USD into tinybar using `transactionReceipt.ExchangeRate` or falling back to `/api/v1/network/exchangerate` * Fix assertion not printing out correct contract call response * Fix regression caused by null immutable key * Fix startup probe topic not being deleted * Fix startup probe taking forever to recover when all nodes are down (cherry picked from commit f72fe73) Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> Signed-off-by: Jesse Nelson <jesse@hashgraph.com> Co-authored-by: Steven Sheehy <17552371+steven-sheehy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
operatorBalanceproperty to store amount in USDtransactionReceipt.ExchangeRateor falling back to/api/v1/network/exchangerateRelated issue(s):
Fixes #8953
Notes for reviewer:
Checklist