feat: Refactor ContractCallAddressThisTest #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9014 +/- ##
=========================================
Coverage 92.14% 92.14%
Complexity 7651 7651
=========================================
Files 929 929
Lines 30583 30583
Branches 3733 3733
=========================================
Hits 28181 28181
Misses 1568 1568
Partials 834 834 ☔ View full report in Codecov by Sentry. |
steven-sheehy
added
enhancement
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev
requested review from
bilyana-gospodinova,
steven-sheehy,
nickeynikolovv and
IvanKavaldzhiev
steven-sheehy
requested changes
Aug 15, 2024
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
...ra-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallAddressThisTest.java
Show resolved
Hide resolved
...ra-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallAddressThisTest.java
Outdated
Show resolved
Hide resolved
...ra-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallAddressThisTest.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jService.java
Outdated
Show resolved
Hide resolved
...ra-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallAddressThisTest.java
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jService.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/web3j/TestWeb3jServiceCustomDeploy.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr refactors ContractCallAddressThisTest to use the new approach with the web3j plugin.
This PR modifies
Modifies ContractCallAddressThisTest to use the new refactoring approach.
Modifies TestWeb3jService adding a possibility to persist contracts during deploy with a custom approach.
Related issue(s):
Fixes #8942
Checklist