Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RecordFileDownloaderPerformanceTest #9021

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Aug 13, 2024

Description:

  • Add a RecordFileDownloaderPerformanceTest
  • Add a hedera.mirror.importer.nodePublicKey property to override all nodes' public key
  • Add a StreamFileWriter to generate and write record, sidecar, and signature files to disk
  • Change hedera.mirror.importer.parser.record.performance to hedera.mirror.importer.test.performance
  • Change performance scenarios to be mapped by name for easy swapping between canonical and new simple scenario
  • Fix importer dashboard including an ALL option for stream type that causes panel issues
  • Fix some grammatical errors in docs
  • Remove performanceTest gradle task to always run performance tests
  • Remove performance Spring profile

Related issue(s):

Fixes #9016

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature performance test Test infrastructure, automated tests required, etc downloader Area: S3 downloader labels Aug 13, 2024
@steven-sheehy steven-sheehy added this to the 0.112.0 milestone Aug 13, 2024
@steven-sheehy steven-sheehy self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (bb82c7b) to head (34bb0c6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9021      +/-   ##
============================================
- Coverage     92.24%   92.14%   -0.11%     
- Complexity     7028     7644     +616     
============================================
  Files           801      929     +128     
  Lines         26867    30571    +3704     
  Branches       3539     3731     +192     
============================================
+ Hits          24784    28169    +3385     
- Misses         1334     1568     +234     
- Partials        749      834      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
Copy link

sonarcloud bot commented Aug 13, 2024

@steven-sheehy steven-sheehy requested a review from a team August 13, 2024 23:08
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mgoelswirlds mgoelswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be super helpful. LGTM

@steven-sheehy steven-sheehy merged commit 8fefa5a into main Aug 15, 2024
31 checks passed
@steven-sheehy steven-sheehy deleted the 9016-recordfiledownloaderperformancetest branch August 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Area: S3 downloader enhancement Type: New feature performance test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a RecordFileDownloaderPerformanceTest
3 participants