Retain existing allowance (spender) columns when updating NFT metadata (0.112) #9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#9115) Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>
jascks
added
bug
steven-sheehy
approved these changes
Aug 22, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.112 #9119 +/- ##
===================================================
- Coverage 92.33% 92.20% -0.13%
- Complexity 7599 7710 +111
===================================================
Files 915 933 +18
Lines 30503 30783 +280
Branches 3727 3752 +25
===================================================
+ Hits 28164 28383 +219
- Misses 1506 1562 +56
- Partials 833 838 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick into 0.112.
Description:
Retain existing spender and delegatingSpender upon NFT metadata update.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist