Refactor ContractCallServiceERCTokenTest delegate transfer
#9163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolov <nikolay.nikolov@limechain.tech>
nickeynikolovv
added
enhancement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9163 +/- ##
============================================
+ Coverage 92.14% 92.27% +0.12%
+ Complexity 7713 7604 -109
============================================
Files 933 915 -18
Lines 30823 30549 -274
Branches 3762 3739 -23
============================================
- Hits 28402 28189 -213
+ Misses 1575 1519 -56
+ Partials 846 841 -5 ☔ View full report in Codecov by Sentry. |
steven-sheehy
approved these changes
Aug 26, 2024
steven-sheehy
deleted the
9162-refactor-contract-call-erc-token-delegate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With this PR the
ContractCallServiceERCTokenTestintegration test file is partially refactored using the web3j plugin and the big enum is now replaced with multiple JUnit tests so that it is easier to debug a particular scenario. This way also the number of persisted entities per test is reduced significantly and now we persist only the ones that are needed in the particular test.This PR refactors delegate transfer test, so it can be more readable.
Related issue(s):
Fixes: #9162
Checklist