91 transactions api performance #92
Conversation
vs_nanos since (a) these fields will be removed, and (b) these don't have indexes - making the queries slow. 2. Added support for caching of responses 3. Added gzip (compression) support 4. Fixed a bug to handle decimal pointin /balances?timestamp=ddddd.dddd query 5. Fixed naming for accounts.test file
API caching configuration
There was a problem hiding this comment.
The cache strategy doesn't make sense.
Use normal cache headers and web caching (or don't bother with caching for now). The better cache solution would be to cache both the page response and query results using something like memcached, and utilize standard HTTP cache headers.
If the data requested is for fixed/unchanging data - cache it. If not, don't cache it. Everything is cached the same way here. So if we know the data for "timestamp_ns=lt:12345" since we've processed up to or past that timestamp, that can be cached, but "timestamp_ns=lt:9999999" where that's past the time we've processed, should not be cached at all. If we cache the latter, we're basically adding a long delay until somebody can get the fresh data.
Disabled cache for now, and took care of all other reivew comments
mike-burrage-hedera
requested review from
gregscullard and
mike-burrage-hedera
steven-sheehy
added
rest
Fixes issue #91