Adjust transaction table indexes #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
jnels124
force-pushed
the
jtn-transacton-index
branch
from
99f06db
to
85ca696
Compare
jnels124
commented
Sep 2, 2024
hedera-mirror-importer/src/main/resources/db/migration/v2/V2.5.1__update_indexes.sql
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9225 +/- ##
============================================
- Coverage 92.84% 92.53% -0.31%
- Complexity 4758 6997 +2239
============================================
Files 672 902 +230
Lines 21638 29562 +7924
Branches 2824 3731 +907
============================================
+ Hits 20090 27356 +7266
- Misses 987 1442 +455
- Partials 561 764 +203 ☔ View full report in Codecov by Sentry. |
hedera-mirror-importer/src/main/resources/db/migration/v2/V2.5.1__update_indexes.sql
Outdated
Show resolved
Hide resolved
|
Probably we should also adjust the doc that shows which endpoints use which index |
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
steven-sheehy
changed the title
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
steven-sheehy
previously approved these changes
Sep 3, 2024
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
steven-sheehy
previously approved these changes
Sep 3, 2024
jnels124
dismissed stale reviews from xin-hedera, steven-sheehy, jascks, and mgoelswirlds
via
3625fef
steven-sheehy
approved these changes
Sep 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adjust transaction indexes for v2 to improve
/api/v1/transactions?account.idand/api/v1/accounts/{id}performanceRelated issue(s):
Fixes #9176
Fixes #5432
Notes for reviewer:
Checklist