Refactor ContractCallServicePrecompileHistoricalTest #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev
added
web3
kselveliev
requested review from
bilyana-gospodinova,
steven-sheehy,
IvanKavaldzhiev and
nickeynikolovv
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9262 +/- ##
============================================
- Coverage 92.64% 92.52% -0.13%
- Complexity 6893 7012 +119
============================================
Files 884 903 +19
Lines 29306 29634 +328
Branches 3709 3737 +28
============================================
+ Hits 27151 27419 +268
- Misses 1396 1447 +51
- Partials 759 768 +9 ☔ View full report in Codecov by Sentry. |
steven-sheehy
added
test
steven-sheehy
previously approved these changes
Sep 3, 2024
...rc/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileHistoricalTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileHistoricalTest.java
Show resolved
Hide resolved
...rc/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileHistoricalTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileHistoricalTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileHistoricalTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
steven-sheehy
previously approved these changes
Sep 4, 2024
steven-sheehy
changed the title
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
|
steven-sheehy
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pr refactors
ContractCallServicePrecompileHistoricalTestto use the web3j plugin.This PR modifies:
ContractCallServicePrecompileHistoricalTest- refactor all methods to use the web3j pluginAbstractContractCallServiceTest- extracted some common methods in it.Added the solidity contract
PrecompileTestContractHistorical.sol to solidity_historical folderRelated issue(s):
Fixes #9072
Notes for reviewer:
Checklist