Add negative scenarios for historical tests #9345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilyana-gospodinova
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9345 +/- ##
============================================
+ Coverage 92.52% 92.55% +0.03%
- Complexity 7012 7016 +4
============================================
Files 904 904
Lines 29669 29669
Branches 3751 3751
============================================
+ Hits 27451 27460 +9
+ Misses 1447 1444 -3
+ Partials 771 765 -6 ☔ View full report in Codecov by Sentry. |
bilyana-gospodinova
changed the title
bilyana-gospodinova
force-pushed
the
09317-add-negative-scenarios-for-historical-tests
branch
from
6dfd6d9
to
2e002a3
Compare
.../src/test/java/com/hedera/mirror/web3/service/ContractCallServiceHistoricalNegativeTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
bilyana-gospodinova
force-pushed
the
09317-add-negative-scenarios-for-historical-tests
branch
from
2e002a3
to
3e0550d
Compare
|
steven-sheehy
deleted the
09317-add-negative-scenarios-for-historical-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds some new test related to the historical scenarios. They verify that the correct data is fetched having a particular historical timestamp. The tests are located in
ContractCallServiceHistoricalNegativeTest.A new abstract class is added -
AbstractContractCallServiceHistoricalTest. It contains some common methods related to the historical data persist.The methods in
AbstractContractCallServiceHistoricalTestandAbstractContractCallServiceTestare named with <entity_type>persist instead of persist<entity_type> in order to use the IDE's auto suggest easily. The second approach would list too much methods as they all start with "p" and this makes the search harder, so I renamed some of the old methods.Fixes #9317
Checklist