Fix web3 docker build #9348
Merged
Fix web3 docker build #9348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9348 +/- ##
============================================
+ Coverage 92.50% 92.52% +0.01%
Complexity 7012 7012
============================================
Files 903 904 +1
Lines 29646 29669 +23
Branches 3739 3751 +12
============================================
+ Hits 27425 27451 +26
+ Misses 1450 1447 -3
Partials 771 771 ☔ View full report in Codecov by Sentry. |
kselveliev
previously approved these changes
Sep 13, 2024
steven-sheehy
requested changes
Sep 13, 2024
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
|
steven-sheehy
approved these changes
Sep 14, 2024
bilyana-gospodinova
added a commit
that referenced
this pull request
Sep 16, 2024
--------- Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recently we added some gradle tasks for compiling historical contracts with older version of solidity - 0.8.7. After assemble task the build/libs directory is polluted with a couple of new 0.8.7-web3j*.jar jars and then running dockerBuild command fails encountering these jars.
This PR adds a new gradle task that deletes the problematic jars.
Fixes #9344
Checklist