Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hedera app dependency to hedera-mirror-web3 #9399

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

IvanKavaldzhiev
Copy link
Contributor

Description:
Add com.hedera.hashgraph:app as a dependency in web3, so that the work for integrating reusable services is unblocked.

In addition, this PR stabilizes some inconsistent failing integration tests.

Fixes #9249

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
@IvanKavaldzhiev IvanKavaldzhiev added enhancement Type: New feature web3 Area: Web3 API labels Sep 18, 2024
@IvanKavaldzhiev IvanKavaldzhiev requested a review from a team September 18, 2024 13:04
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (90dca10) to head (a76472c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...r/web3/evm/properties/MirrorNodeEvmProperties.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9399      +/-   ##
============================================
- Coverage     92.68%   92.56%   -0.12%     
- Complexity     6943     7047     +104     
============================================
  Files           896      914      +18     
  Lines         29553    29810     +257     
  Branches       3745     3767      +22     
============================================
+ Hits          27390    27595     +205     
- Misses         1399     1445      +46     
- Partials        764      770       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-sheehy steven-sheehy added this to the 0.115.0 milestone Sep 18, 2024
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 5d00263 into main Sep 19, 2024
27 of 29 checks passed
@steven-sheehy steven-sheehy deleted the 09249-add-hedera-app-dependency branch September 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hedera.app dependency into hedera-mirror-node
2 participants