-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hedera app dependency to hedera-mirror-web3 #9399
Conversation
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9399 +/- ##
============================================
- Coverage 92.68% 92.56% -0.12%
- Complexity 6943 7047 +104
============================================
Files 896 914 +18
Lines 29553 29810 +257
Branches 3745 3767 +22
============================================
+ Hits 27390 27595 +205
- Misses 1399 1445 +46
- Partials 764 770 +6 ☔ View full report in Codecov by Sentry. |
...mirror-web3/src/main/java/com/hedera/mirror/web3/evm/properties/MirrorNodeEvmProperties.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/convert/SemanticVersionConvertor.java
Outdated
Show resolved
Hide resolved
...mirror-web3/src/main/java/com/hedera/mirror/web3/evm/properties/MirrorNodeEvmProperties.java
Outdated
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/convert/SemanticVersionConvertor.java
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Add
com.hedera.hashgraph:app
as a dependency in web3, so that the work for integrating reusable services is unblocked.In addition, this PR stabilizes some inconsistent failing integration tests.
Fixes #9249
Notes for reviewer:
Checklist