Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response codes for protobuf 0.54.0 #9487

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

edwin-greene
Copy link
Contributor

Description:
Adds response codes from 0.54.0:
https://github.com/hashgraph/hedera-services/blob/release/0.54/hapi/hedera-protobufs/services/response_code.proto

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
@edwin-greene edwin-greene added enhancement Type: New feature rest Area: REST API labels Oct 1, 2024
@edwin-greene edwin-greene added this to the 0.115.0 milestone Oct 1, 2024
@edwin-greene edwin-greene self-assigned this Oct 1, 2024
@edwin-greene edwin-greene requested a review from a team October 1, 2024 15:22
Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (19d22d2) to head (fee8e46).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9487   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity     7047     7047           
=========================================
  Files           915      915           
  Lines         29870    29870           
  Branches       3773     3773           
=========================================
  Hits          27653    27653           
  Misses         1446     1446           
  Partials        771      771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwin-greene edwin-greene merged commit 225611c into main Oct 1, 2024
32 checks passed
@edwin-greene edwin-greene deleted the updateProtobuf0_54_0 branch October 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants