Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node metrics to monitor metrics #9531

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

steven-sheehy
Copy link
Member

Description:

  • Add environment tag to all monitor metrics
  • Add host tag to monitor publish metrics
  • Add port tag to monitor publish metrics
  • Change node tag in monitor metrics from account ID to node ID
  • Fix byte buddy warnings in test logs
  • Fix use of deprecated closure in Gradle

Related issue(s):

Fixes #8874

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature monitor Area: Monitoring and dashboard labels Oct 7, 2024
@steven-sheehy steven-sheehy added this to the 0.116.0 milestone Oct 7, 2024
@steven-sheehy steven-sheehy requested a review from a team October 7, 2024 14:39
@steven-sheehy steven-sheehy self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.34%. Comparing base (408b001) to head (1afb639).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../hedera/mirror/monitor/publish/PublishMetrics.java 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9531      +/-   ##
============================================
- Coverage     92.34%   92.34%   -0.01%     
- Complexity     7218     7221       +3     
============================================
  Files           921      921              
  Lines         30515    30535      +20     
  Branches       3884     3885       +1     
============================================
+ Hits          28180    28197      +17     
- Misses         1487     1489       +2     
- Partials        848      849       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

@shezaan-hashgraph shezaan-hashgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for tackling this issue.

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 8fb7f1a into main Oct 7, 2024
32 of 33 checks passed
@steven-sheehy steven-sheehy deleted the 8874-monitor-labels branch October 7, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature monitor Area: Monitoring and dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to all hedera-mirror-monitor metrics
4 participants