-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node metrics to monitor metrics #9531
Conversation
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9531 +/- ##
============================================
- Coverage 92.34% 92.34% -0.01%
- Complexity 7218 7221 +3
============================================
Files 921 921
Lines 30515 30535 +20
Branches 3884 3885 +1
============================================
+ Hits 28180 28197 +17
- Misses 1487 1489 +2
- Partials 848 849 +1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for tackling this issue.
hedera-mirror-monitor/src/main/java/com/hedera/mirror/monitor/NodeProperties.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
environment
tag to all monitor metricshost
tag to monitor publish metricsport
tag to monitor publish metricsnode
tag in monitor metrics from account ID to node IDRelated issue(s):
Fixes #8874
Notes for reviewer:
Checklist