Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jooq repository to improve reusability (0.115.0) #9535

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

edwin-greene
Copy link
Contributor

@edwin-greene edwin-greene commented Oct 8, 2024

  • Update jooqRepository and simplify conditionals

Signed-off-by: Edwin Greene edwin@hashgraph.com
(cherry picked from commit 75dc606)

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Update jooqRepository and simplify conditionals

Signed-off-by: Edwin Greene <edwin@hashgraph.com>
(cherry picked from commit 75dc606)
@edwin-greene edwin-greene added enhancement Type: New feature rest-java Area: Java REST API labels Oct 8, 2024
@edwin-greene edwin-greene added this to the 0.115.0 milestone Oct 8, 2024
@edwin-greene edwin-greene self-assigned this Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (94dc03d) to head (e7c927a).
Report is 1 commits behind head on release/0.115.

Files with missing lines Patch % Lines
...era/mirror/restjava/repository/JooqRepository.java 93.87% 0 Missing and 3 partials ⚠️
...m/hedera/mirror/restjava/common/RangeOperator.java 0.00% 0 Missing and 1 partial ⚠️
.../hedera/mirror/restjava/common/RangeParameter.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.115    #9535   +/-   ##
================================================
  Coverage            92.58%   92.58%           
- Complexity            7047     7081   +34     
================================================
  Files                  915      916    +1     
  Lines                29870    29913   +43     
  Branches              3773     3779    +6     
================================================
+ Hits                 27654    27695   +41     
+ Misses                1446     1445    -1     
- Partials               770      773    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-sheehy steven-sheehy requested a review from a team October 8, 2024 17:31
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwin-greene edwin-greene merged commit f012e21 into release/0.115 Oct 8, 2024
33 checks passed
@edwin-greene edwin-greene deleted the addJooqRefactor-0-115-0 branch October 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest-java Area: Java REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants