Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFTs to airdrop REST APIs (0.115.0) #9536

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

edwin-greene
Copy link
Contributor

  • Add Nfts to airdrops endpoints

Signed-off-by: Edwin Greene edwin@hashgraph.com
(cherry picked from commit 4ba4b4f)

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Add Nfts to airdrops endpoints

Signed-off-by: Edwin Greene <edwin@hashgraph.com>
(cherry picked from commit 4ba4b4f)
@edwin-greene edwin-greene added enhancement Type: New feature rest-java Area: Java REST API labels Oct 8, 2024
@edwin-greene edwin-greene added this to the 0.115.0 milestone Oct 8, 2024
@edwin-greene edwin-greene self-assigned this Oct 8, 2024
@edwin-greene edwin-greene requested a review from a team October 8, 2024 19:54
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (f012e21) to head (46d813c).
Report is 1 commits behind head on release/0.115.

Files with missing lines Patch % Lines
...r/restjava/controller/TokenAirdropsController.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.115    #9536   +/-   ##
================================================
  Coverage            92.58%   92.58%           
- Complexity            7081     7085    +4     
================================================
  Files                  916      916           
  Lines                29913    29921    +8     
  Branches              3779     3781    +2     
================================================
+ Hits                 27695    27703    +8     
  Misses                1445     1445           
  Partials               773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwin-greene edwin-greene merged commit c75d2b4 into release/0.115 Oct 9, 2024
32 of 33 checks passed
@edwin-greene edwin-greene deleted the addNfts-0-115-0 branch October 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest-java Area: Java REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants