Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc-netty-shaded from 1.27.2 to 1.30.2 #963

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 17, 2020

Bumps grpc-netty-shaded from 1.27.2 to 1.31.1.

Release notes

Sourced from grpc-netty-shaded's releases.

v1.31.1

Bug Fixes:

  • netty: The environment variable GRPC_EXPERIMENTAL_AUTOFLOWCONTROL=false will now disable the BDP monitoring introduced in v1.30.0. This is intended to help diagnose a “too_many_pings” compatibility issue and will be removed once it is resolved. If you need to use the variable, please file an issue
  • examples: some gRPC artifacts are missing in JCenter causing Android examples to sometimes fail to build. Now we are adding mavenCentral as fallback for the Android examples. See #5782
  • xds: meshCA protocol buffers added in v1.31.0 are now properly shaded in an internal package
  • xds: fixed some internal breakage for traffic splitting

v1.31.0

API Changes

  • api: ManagedChannelBuilder.nameResolverFactory is now marked deprecated. It has long been our plan to remove the function, but was not communicated. Most usages should be able to globally register via the SPI mechanism or NameResolverRegistry.register(). There is a plan to add a method to ManagedChannelBuilder to specify the default target scheme for the channel. If your use-case is not covered, please inform us on #7133

New Features

  • The following new xDS functionality is added in this release:
    • Requests matching based on path (prefix, full path and safe regex) and headers.
    • Requests routing to multiple clusters based on weights.
    • The xDS features supported in a given release are documented here.
  • api: Added LoadBalancer.Helper.createResolvingOobChannelBuilder(). It is similar to LoadBalancer.Helper.createResolvingOobChannel() except allows configuring the channel (#7136)

Bug Fixes

  • netty: return status code unavailable when netty channel has unresolved InetSocketAddress (#7023)
  • core: fix a bug that a call may hang when using manual flow control and gRPC retry is enabled (#6817)

Documentation

  • stub: Documented more behavior of ClientCalls and ServerCalls, with regard to ClientResponseObserver, ClientCallStreamObserver, ServerCallStreamObserver, and exceptions
  • api: Documented how Providers may be used in their respective class documentation. Previously you “just had to know” the SPI mechanism was available

Dependencies

  • Update guava to 29.0 (#7079)

Examples

  • examples: Add client/server retrying example via service config #7111

Acknowledgements

@alexanderscott @AnarSultanov @cindyxue @d-reidenbach @elharo @gsharma @reggiemcdonald

v1.30.2 patch release

Bug Fixes

Commits
  • 396dca3 Bump version to 1.31.1
  • 8604814 Update README etc to reference 1.31.1
  • 268a35c README: link to v1.31.0 example directories
  • 417a8f7 xds: manage load stats for all clusters in XdsClient (v1.31.x backport) (#729...
  • 0abff44 xds: support load reporting all clusters option and fix actual report interva...
  • 491c9e2 xds: add header matching special cases for hiding/exposing some gRPC headers ...
  • 9e58c52 netty: Provide an environment variable to toggle BDP monitoring
  • 7416577 examples: add mavenCentral for android example's dependency repository (v1.31...
  • cbb0f17 xds: shade the meshCA proto generated code (#7292)
  • 141c8d8 Bump version to 1.31.1-SNAPSHOT
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [grpc-netty-shaded](https://github.com/grpc/grpc-java) from 1.27.2 to 1.31.1.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](grpc/grpc-java@v1.27.2...v1.31.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Type: Pull requests that update a dependency file java Pull requests that update Java code labels Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #963   +/-   ##
=========================================
  Coverage     86.81%   86.81%           
  Complexity      210      210           
=========================================
  Files           168      168           
  Lines          4233     4233           
  Branches        466      466           
=========================================
  Hits           3675     3675           
  Misses          411      411           
  Partials        147      147           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fd703...7c92f34. Read the comment docs.

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run acceptance tests prior to check in.
Acceptance
./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@sanity" -Dspring.config.name=application-perf

Cucumber acceptance tests were affected once in the past when we upgraded the grpc-netty-shaded version. I believe @steven-sheehy had a suggestion on how to modify the dependencies to avoid that issue. Subsequently Cucumber might have fixed the issue and this will work fin.

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@Nana-EC Nana-EC self-assigned this Aug 25, 2020
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limited bump to 1.30.2 (current project grpc version used) and verified acceptance tests.
1.31.1 cause tests to not startup, might be related to grpc module version being lower, ut this can be looked into later

@Nana-EC Nana-EC changed the title Bump grpc-netty-shaded from 1.27.2 to 1.31.1 Bump grpc-netty-shaded from 1.27.2 to 1.30.2 Aug 25, 2020
@Nana-EC Nana-EC added this to the Mirror 0.18.0 milestone Aug 25, 2020
@Nana-EC Nana-EC merged commit 7ac2cc5 into master Aug 25, 2020
@Nana-EC Nana-EC deleted the dependabot/maven/io.grpc-grpc-netty-shaded-1.31.1 branch August 25, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file java Pull requests that update Java code P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants