Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/record log bug fixes - Addresses #101 #97

Merged
merged 6 commits into from
Aug 27, 2019

Conversation

gregscullard
Copy link
Contributor

Current code assumed starting loading data from day 0 which resulted in an assumption that an entity would always exist when it's updated, deleted, etc... which isn't the case.

These fixes ensure an entity is first created if it doesn't already exist.

Copy link
Contributor

@mike-burrage-hedera mike-burrage-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 1 small change for clarity.

src/main/java/com/hedera/recordFileLogger/Entities.java Outdated Show resolved Hide resolved
@gregscullard gregscullard changed the title Fix/record log bug fixes Fix/record log bug fixes - Addresses #101 Aug 27, 2019
@gregscullard
Copy link
Contributor Author

Addresses issue #101

@mike-burrage-hedera mike-burrage-hedera merged commit b50ded3 into master Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/recordLogBugFixes branch August 27, 2019 01:15
@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 parser Area: File parsing labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 parser Area: File parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants