Fix contract deployment with value (0.117) #9703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes contract deployment when the contract deployment is made with value. This PR modifies : Modified ContractCallRequest - change the 'to' validation to check if the call is for contract deployment BytecodeUtils - Added a new method isInitBytecode which checks if a given data is an init bytecode - needed in ContractCallRequest validation ContractControllerTest - Added new test and modified a few existing ones based on the new changes to the validation of the to field. Modified ContractCallAddressThisTest - added tests for deployment of payable contract with and without value Modified ContractCallServiceERCTokenModificationFunctionsTest - added tests for deployment of non payable contract with and without value. --------- Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
steven-sheehy
changed the title
steven-sheehy
approved these changes
Nov 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.117 #9703 +/- ##
===================================================
- Coverage 92.23% 92.22% -0.01%
- Complexity 7609 7622 +13
===================================================
Files 933 934 +1
Lines 32000 32019 +19
Branches 4042 4045 +3
===================================================
+ Hits 29515 29530 +15
- Misses 1536 1537 +1
- Partials 949 952 +3 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick fix from -> 6a42166
This PR fixes contract deployment when the contract deployment is made with value.
This PR modifies :
Modified ContractCallRequest - change the 'to' validation to check if the call is for contract deployment
BytecodeUtils - Added a new method isInitBytecode which checks if a given data is an init bytecode - needed in ContractCallRequest validation
ContractControllerTest - Added new test and modified a few existing ones based on the new changes to the validation of the to field.
Modified ContractCallAddressThisTest - added tests for deployment of payable contract with and without value
Modified ContractCallServiceERCTokenModificationFunctionsTest - added tests for deployment of non payable contract with and without value.
Related issue(s):
Fixes #9636
Notes for reviewer:
Checklist