Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance tests expecting a memo #9706

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

steven-sheehy
Copy link
Member

Description:

Fix acceptance tests expecting a memo after change in consensus nodes

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Nov 4, 2024
@steven-sheehy steven-sheehy added this to the 0.118.0 milestone Nov 4, 2024
@steven-sheehy steven-sheehy self-assigned this Nov 4, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner November 4, 2024 21:21
Copy link

sonarcloud bot commented Nov 4, 2024

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (79acda2) to head (60256e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9706      +/-   ##
============================================
+ Coverage     92.23%   92.32%   +0.09%     
+ Complexity     7628     7524     -104     
============================================
  Files           937      919      -18     
  Lines         32115    31859     -256     
  Branches       4067     4045      -22     
============================================
- Hits          29621    29415     -206     
+ Misses         1542     1496      -46     
+ Partials        952      948       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 1df049c into main Nov 4, 2024
33 checks passed
@steven-sheehy steven-sheehy deleted the fix-acceptance-memo branch November 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants