Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registering of systemTransactionEncoder callback to all missing places #17610

Open
15 tasks
IvanKavaldzhiev opened this issue Jan 29, 2025 · 1 comment · May be fixed by #17612
Open
15 tasks

Fix registering of systemTransactionEncoder callback to all missing places #17610

IvanKavaldzhiev opened this issue Jan 29, 2025 · 1 comment · May be fixed by #17612
Assignees
@IvanKavaldzhiev
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Platform Tickets pertaining to the platform

Comments

@IvanKavaldzhiev
Copy link
Collaborator

Background

Currently we register a callback called systemTransactionEncoder that encodes a StateSignatureTransaction to Bytes using a method from SwirldMain. It seems it's not registered on every place and some demo apps are failing.

Acceptance Criteria

Register the callback on every place it's missing.

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
@IvanKavaldzhiev IvanKavaldzhiev added Bug An error that causes the feature to behave differently than what was expected based on design. Platform Tickets pertaining to the platform labels Jan 29, 2025
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Jan 29, 2025
@mxtartaglia-sl
Copy link
Contributor

This is also an issue for turtle

@IvanKavaldzhiev IvanKavaldzhiev linked a pull request Jan 29, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanKavaldzhiev IvanKavaldzhiev

Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Platform Tickets pertaining to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: register systemTransactionEncoderCallback on missing places hashgraph/hedera-services
2 participants
@IvanKavaldzhiev @mxtartaglia-sl