Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register systemTransactionEncoderCallback on missing places #17612

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

IvanKavaldzhiev
Copy link
Collaborator

Description:
Fixes registering of a callback that encodes StateSignatureTransactions to Bytes on all missing places. Applies to demo test applications and TurtleTests

Related issue(s):

Fixes #17610

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
@IvanKavaldzhiev IvanKavaldzhiev added Bug An error that causes the feature to behave differently than what was expected based on design. Platform Tickets pertaining to the platform labels Jan 29, 2025
@IvanKavaldzhiev IvanKavaldzhiev added this to the v0.59 milestone Jan 29, 2025
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Jan 29, 2025
@IvanKavaldzhiev IvanKavaldzhiev requested review from a team as code owners January 29, 2025 18:14
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (b17a761) to head (af8a9ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17612      +/-   ##
============================================
+ Coverage     68.93%   68.94%   +0.01%     
- Complexity    22853    22859       +6     
============================================
  Files          2630     2630              
  Lines         98775    98775              
  Branches      10256    10256              
============================================
+ Hits          68091    68101      +10     
+ Misses        26792    26783       -9     
+ Partials       3892     3891       -1     
Files with missing lines Coverage Δ
...swirlds/platform/builder/ApplicationCallbacks.java 100.00% <ø> (ø)
...n/java/com/swirlds/platform/system/SwirldMain.java 0.00% <ø> (ø)
...rc/main/java/com/hedera/node/app/ServicesMain.java 27.97% <0.00%> (-0.20%) ⬇️

... and 14 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b17a761) 98558 71831 72.88%
Head commit (af8a9ae) 98558 (+0) 71840 (+9) 72.89% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17612) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@lpetrovic05
Copy link
Member

These apps seem to be missing the handling of these signature transactions

@lpetrovic05
Copy link
Member

also, we should get rid of the default method in the interface

Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
lpetrovic05
lpetrovic05 previously approved these changes Jan 31, 2025
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Jan 31, 2025
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix registering of systemTransactionEncoder callback to all missing places
3 participants