-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register systemTransactionEncoderCallback on missing places #17612
base: main
Are you sure you want to change the base?
fix: register systemTransactionEncoderCallback on missing places #17612
Conversation
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
...m-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17612 +/- ##
============================================
+ Coverage 68.93% 68.94% +0.01%
- Complexity 22853 22859 +6
============================================
Files 2630 2630
Lines 98775 98775
Branches 10256 10256
============================================
+ Hits 68091 68101 +10
+ Misses 26792 26783 -9
+ Partials 3892 3891 -1
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…ng-callback-on-missing-places
...m-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java
Outdated
Show resolved
Hide resolved
These apps seem to be missing the handling of these signature transactions |
also, we should get rid of the default method in the interface |
…ng-callback-on-missing-places
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…ng-callback-on-missing-places
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Description:
Fixes registering of a callback that encodes StateSignatureTransactions to Bytes on all missing places. Applies to demo test applications and TurtleTests
Related issue(s):
Fixes #17610
Notes for reviewer:
Checklist