-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updates to match recent changes to the Block Stream definition #16099
Conversation
5a345dc
to
e50a9f2
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16099 +/- ##
=============================================
+ Coverage 63.35% 63.36% +0.01%
- Complexity 20103 20107 +4
=============================================
Files 2527 2527
Lines 93722 93726 +4
Branches 9811 9811
=============================================
+ Hits 59381 59393 +12
+ Misses 30741 30734 -7
+ Partials 3600 3599 -1
|
fb66386
to
80b39d9
Compare
Node: HAPI Test (Restart) Results9 files 1 errors 8 suites 4m 41s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 2d0c151. ♻️ This comment has been updated with latest results. |
25697f8
to
2d0c151
Compare
* Updated the block service definitions * Split one monolithic service into a few modular services * Modified the _publish_ service to match agreed protocol. * Removed the modification to temporarily work around multiple bugs in PBJ (bug 280, and an already-fixed bug in comment handling). * Merged a few other small changes * Updates to protobuf files to fix indentation and malformed HTML tags. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
86cf740
2d0c151
to
86cf740
Compare
* Updated block stream builder to remove exchange rates from transaction result * Updated `BlockItemsTranslator` to read exchange rates from the `TranslationContext`. * Updated all 12 `TranslationContext` implementations to carry the exchange rates * Updated BlockStreamBuilder to store the exchange rates in the translation context only. * Updated BlockStreamBuilderTest as needed * Fixed other tests as needed. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
86cf740
to
f5cd37c
Compare
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
rather than one-at-a-time.