Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set test clients and embedded node to use non-zero shard/realm #17601

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vtronkov
Copy link
Contributor

@vtronkov vtronkov commented Jan 29, 2025

Description:
Make the test client and the embedded node easily configurable with non-zero shard/realm

Related issue(s):

Fixes #17604

Notes for reviewer:

  • Change the spec-default.properties to only point to account/file numbers without the shard/realm
  • Change the HapiPropertySource.java to append the shard/realm that is read from the configuration
  • Change the embedded node to set the shard/realm reading it from the configuration

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov changed the title set test clients and embedded node to use non-zero shard/realm feature: Set test clients and embedded node to use non-zero shard/realm Jan 29, 2025
@vtronkov vtronkov added this to the v0.60 milestone Jan 29, 2025
@vtronkov vtronkov changed the title feature: Set test clients and embedded node to use non-zero shard/realm feat: Set test clients and embedded node to use non-zero shard/realm Jan 29, 2025
@vtronkov vtronkov changed the title feat: Set test clients and embedded node to use non-zero shard/realm feat: set test clients and embedded node to use non-zero shard/realm Jan 29, 2025
Copy link

codacy-production bot commented Jan 29, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a45666e) 98558 71826 72.88%
Head commit (1b49a62) 98558 (+0) 71826 (+0) 72.88% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17601) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (a45666e) to head (1b49a62).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17601   +/-   ##
=========================================
  Coverage     68.92%   68.92%           
  Complexity    22850    22850           
=========================================
  Files          2630     2630           
  Lines         98775    98775           
  Branches      10256    10256           
=========================================
  Hits          68084    68084           
  Misses        26797    26797           
  Partials       3894     3894           

Impacted file tree graph

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov marked this pull request as ready for review January 29, 2025 10:10
@vtronkov vtronkov requested review from a team as code owners January 29, 2025 10:10
@vtronkov vtronkov requested a review from iwsimon January 29, 2025 10:10
Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vtronkov

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test clients and embedded node to use non-zero shard/realm
7 participants