-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set test clients and embedded node to use non-zero shard/realm #17601
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17601 +/- ##
=========================================
Coverage 68.92% 68.92%
Complexity 22850 22850
=========================================
Files 2630 2630
Lines 98775 98775
Branches 10256 10256
=========================================
Hits 68084 68084
Misses 26797 26797
Partials 3894 3894 |
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vtronkov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description:
Make the test client and the embedded node easily configurable with non-zero shard/realm
Related issue(s):
Fixes #17604
Notes for reviewer:
spec-default.properties
to only point to account/file numbers without the shard/realmHapiPropertySource.java
to append the shard/realm that is read from the configuration