-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement system contract versioning foundation #17611
Conversation
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - good start at this feature!
I will add to my new smart contract service metrics epic a task to consider per-address metrics, e.g., how many times 0x167
is called vs 0x169
, etc.
...src/main/java/com/hedera/node/app/service/contract/impl/exec/utils/SystemContractMethod.java
Outdated
Show resolved
Hide resolved
...m/hedera/node/app/service/contract/impl/exec/systemcontracts/common/AbstractCallAttempt.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hedera/node/app/service/contract/impl/exec/utils/SystemContractMethod.java
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ContractsConfig.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java
Outdated
Show resolved
Hide resolved
...n/java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/HtsSystemContract.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hedera/node/app/service/contract/impl/exec/processors/ProcessorModule.java
Show resolved
Hide resolved
...vice/contract/impl/exec/systemcontracts/hts/address_0x16c/balanceof/BalanceOfTranslator.java
Outdated
Show resolved
Hide resolved
...dera/node/app/service/contract/impl/test/exec/processors/CustomMessageCallProcessorTest.java
Show resolved
Hide resolved
…nto 17494-base-system-contract-versioning
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess we can move the 0x167 system contracts to a new address_0x167 dir at some point?
This a great effort @lukelee-sl
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from hedera-services
changes ! Thanks @lukelee-sl
Description:
Implement foundational changes for system contract versioning. Current state is that the feature is turned off with only calls to 0x167 allowed for HTS system contracts
Related issue(s):
Fixes #17493
Notes for reviewer:
Checklist