Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the AtomicBatchHandler.handle() method #17624

Merged
merged 23 commits into from
Feb 5, 2025

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Jan 30, 2025

Description:

Related issue(s):

Fixes #17370

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

JivkoKelchev and others added 13 commits January 15, 2025 12:51
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
…ransaction()

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
# Conflicts:
#	hapi/hedera-protobufs/services/response_code.proto
#	hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/workflows/HandleContext.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/DispatchHandleContext.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/dispatch/ChildDispatchFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/steps/UserTxnFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/standalone/impl/StandaloneDispatchFactory.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/DispatchHandleContextTest.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnVerbs.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/util/HapiAtomicBatch.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchTest.java
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon requested review from a team as code owners January 30, 2025 20:38
@iwsimon iwsimon changed the base branch from main to hip-551-batch-txs January 30, 2025 20:40
@iwsimon iwsimon changed the title 17373-batch-handle feat: Implement the AtomicBatchHandler.handle() method Jan 30, 2025
@iwsimon iwsimon self-assigned this Jan 30, 2025
@iwsimon iwsimon added this to the v0.60 milestone Jan 30, 2025
@iwsimon iwsimon changed the title feat: Implement the AtomicBatchHandler.handle() method feat: implement the AtomicBatchHandler.handle() method Jan 30, 2025
@iwsimon iwsimon removed their assignment Jan 30, 2025
@iwsimon iwsimon self-assigned this Jan 30, 2025
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Copy link

codacy-production bot commented Jan 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9e3f1961 82.61%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9e3f196) Report Missing Report Missing Report Missing
Head commit (8801266) 98967 72200 72.95%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17624) 23 19 82.61%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (hip-551-batch-txs@9e3f196). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...de/app/workflows/handle/DispatchHandleContext.java 0.00% 4 Missing ⚠️
...service/util/impl/handlers/AtomicBatchHandler.java 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             hip-551-batch-txs   #17624   +/-   ##
====================================================
  Coverage                     ?   69.01%           
  Complexity                   ?    22917           
====================================================
  Files                        ?     2645           
  Lines                        ?    99190           
  Branches                     ?    10268           
====================================================
  Hits                         ?    68458           
  Misses                       ?    26839           
  Partials                     ?     3893           
Files with missing lines Coverage Δ
...hedera/node/app/spi/workflows/DispatchOptions.java 100.00% <100.00%> (ø)
...m/hedera/node/app/spi/workflows/HandleContext.java 82.35% <ø> (ø)
...a/node/app/workflows/handle/DispatchProcessor.java 95.04% <ø> (ø)
...service/util/impl/handlers/AtomicBatchHandler.java 61.53% <88.23%> (ø)
...de/app/workflows/handle/DispatchHandleContext.java 91.42% <0.00%> (ø)

Impacted file tree graph

iwsimon and others added 9 commits January 31, 2025 17:28
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/dispatch/ChildDispatchFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/steps/UserTxnFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/standalone/impl/StandaloneDispatchFactory.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/DispatchHandleContextTest.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/dispatch/ChildDispatchFactoryTest.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/steps/UserTxnTest.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchTest.java
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
…hing field 'nanos' Matching field 'parent_consensus_timestamp'

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @iwsimon !

@iwsimon iwsimon merged commit 757d32b into hip-551-batch-txs Feb 5, 2025
44 of 45 checks passed
@iwsimon iwsimon deleted the 17373-batch-handle branch February 5, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants