Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unwanted post-upgrade work #17631

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (a45666e) to head (803f371).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...dera/node/app/workflows/handle/HandleWorkflow.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17631      +/-   ##
============================================
+ Coverage     68.92%   68.95%   +0.02%     
- Complexity    22850    22854       +4     
============================================
  Files          2630     2629       -1     
  Lines         98775    98710      -65     
  Branches      10256    10251       -5     
============================================
- Hits          68084    68064      -20     
+ Misses        26797    26762      -35     
+ Partials       3894     3884      -10     
Files with missing lines Coverage Δ
...app/workflows/handle/steps/StakePeriodChanges.java 88.23% <ø> (+0.30%) ⬆️
...e/token/impl/handlers/staking/StakeInfoHelper.java 96.15% <ø> (-0.63%) ⬇️
...dera/node/app/workflows/handle/HandleWorkflow.java 64.16% <66.66%> (-0.42%) ⬇️

... and 11 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a45666e) 98558 71826 72.88%
Head commit (803f371) 98493 (-65) 71796 (-30) 72.89% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17631) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tinker-michaelj tinker-michaelj marked this pull request as draft January 31, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(0.58+) Unwanted post-upgrade synthetic NodeStakeUpdate
1 participant