Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconnect leaves event creation manager in OVERLOADED state #17658

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OlegMazurov
Copy link
Contributor

Description:

  • introduced DIRECT input wire
  • used DIRECT input wire to report unhealthy duration to event creation manager

Related issue(s):

Fixes #17180

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
@OlegMazurov OlegMazurov requested review from a team as code owners January 31, 2025 17:02
@OlegMazurov OlegMazurov marked this pull request as draft January 31, 2025 17:03
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 75.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2c007f9) 98556 71847 72.90%
Head commit (793674b) 98561 (+5) 71846 (-1) 72.89% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17658) 8 6 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (2c007f9) to head (793674b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lds/component/framework/wires/input/InputWire.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17658      +/-   ##
============================================
- Coverage     68.95%   68.95%   -0.01%     
+ Complexity    22864    22862       -2     
============================================
  Files          2630     2630              
  Lines         98773    98778       +5     
  Branches      10256    10256              
============================================
- Hits          68113    68109       -4     
- Misses        26774    26780       +6     
- Partials       3886     3889       +3     
Files with missing lines Coverage Δ
...omponent/framework/model/TraceableWiringModel.java 80.48% <100.00%> (ø)
.../swirlds/component/framework/wires/SolderType.java 100.00% <100.00%> (ø)
...s/component/framework/wires/output/OutputWire.java 96.22% <100.00%> (+0.07%) ⬆️
...va/com/swirlds/platform/wiring/PlatformWiring.java 81.06% <100.00%> (+0.04%) ⬆️
...lds/component/framework/wires/input/InputWire.java 80.00% <0.00%> (-8.89%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 2 never returns to ACTIVE after reconnect in FCM-VM-MultiSBReconnect-3R-1k-20m JRS Test
1 participant