chore: Mirror block stream update from protobufs to services #17663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17663 +/- ##
============================================
- Coverage 69.00% 68.98% -0.02%
+ Complexity 22918 22915 -3
============================================
Files 2639 2639
Lines 98950 98950
Branches 10261 10261
============================================
- Hits 68278 68265 -13
- Misses 26783 26794 +11
- Partials 3889 3891 +2 see 12 files with indirect coverage changes |
jsync-swirlds
force-pushed
the
chore-mirror-block-stream-change
branch
2 times, most recently
from
4fd1e26 to
7fa56a4
Compare
* Adjust Block Stream to ensure a newly created account is identifiable * Added a created account ID to the CreateAccountOutput. * Added CreateAccountOutput to the TransactionOutput oneOf. Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
jsync-swirlds
force-pushed
the
chore-mirror-block-stream-change
branch
from
7fa56a4 to
041d04d
Compare
Nana-EC
reviewed
Feb 3, 2025
Neeharika-Sompalli
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
LGTM other than a documentation comment. Thanks @jsync-swirlds
Neeharika-Sompalli
approved these changes
Feb 4, 2025
2 tasks
MiroslavGatsanoga
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
2 tasks
MiroslavGatsanoga
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Joseph S. 121976561+jsync-swirlds@users.noreply.github.com
MiroslavGatsanoga
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Joseph S. 121976561+jsync-swirlds@users.noreply.github.com Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror of the PR in hedera-protobufs